-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value in denylist #583
Merged
Merged
+155
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
November 6, 2023 19:01
heemin32
added
skip-changelog
backport 2.x
Backport PR to 2.x branch
backport 2.11
Backport to 2.11 branch
labels
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a unit test that is checking this default value? Not a blocker, just maybe add it in a separate PR
junqiu-lei
approved these changes
Nov 6, 2023
martin-gaievski
approved these changes
Nov 6, 2023
heemin32
force-pushed
the
internal
branch
5 times, most recently
from
November 6, 2023 20:15
2c0f9a0
to
1c7e8ff
Compare
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
============================================
- Coverage 89.03% 89.00% -0.04%
+ Complexity 767 766 -1
============================================
Files 93 93
Lines 2746 2746
Branches 223 223
============================================
- Hits 2445 2444 -1
Misses 221 221
- Partials 80 81 +1
|
Signed-off-by: Heemin Kim <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit e91b47c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit e91b47c)
heemin32
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit e91b47c) Co-authored-by: Heemin Kim <[email protected]>
heemin32
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit e91b47c) Co-authored-by: Heemin Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default value in denylist
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.